slightly more useful user agent #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
approved these changes
Oct 21, 2020
hsanjuan
reviewed
Oct 22, 2020
| if err != nil { | ||
| pn = defaultClientExec | ||
| } | ||
| agent := fmt.Sprintf("drand-client-%s/1.0", path.Base(pn)) |
There was a problem hiding this comment.
Shouldn't it use the actual version instead of 1.0 ? (per comment here)
There was a problem hiding this comment.
Actually, I see the other PR does a full overwrite. But still what does 1.0 mean.
There was a problem hiding this comment.
there isn't a way to know what version of the drand module has been loaded into another binary at build time. unless we defined a constant in the go source code that we update on each release it's going to be out of date with the drand version.
that's not something the go build system can help us with afaik
There was a problem hiding this comment.
1.0 here means this is the first version that's using this version string scheme 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.