Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make 'polling client watch failed' errors more detailed #794

Merged
merged 3 commits into from
Apr 14, 2021
Merged

make 'polling client watch failed' errors more detailed #794

merged 3 commits into from
Apr 14, 2021

Conversation

willscott
Copy link
Member

fix #793

@willscott willscott requested a review from hsanjuan March 1, 2021 22:38
hsanjuan
hsanjuan approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@hsanjuan hsanjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @willscott !

@willscott
Copy link
Member Author

TestBroadcast seems to be failing very reliably, which is scary 🤔

@willscott willscott merged commit 60b060c into master Apr 14, 2021
@willscott willscott deleted the fix/polling_verbosity branch April 14, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsanjuan hsanjuan hsanjuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

in the "failed to watch" messages: we need to add what failed to watch exactly.
2 participants
@willscott @hsanjuan