Test for broadcast based on callbacks instead of timeouts #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 15, 2021
Merged
willscott
approved these changes
Mar 18, 2021
| // by drand to both (1) be the interface between drand and the dkg logic and (2) | ||
| // implement the broadcasting mechanisn. | ||
| type Broadcast interface { | ||
| dkg.Board |
There was a problem hiding this comment.
this makes for a very 'wide' interface. is it possible to have a GetBoard() method in the interface that returns a dkg.Board rather than saying that as Broadcast is a Board?
|
Merging to unbreak tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were always passing locally on my machine but apparently not on Travis - I switched to having tests based on callbacks so travis weird timings doesn't influence test outcome.