Use of zap log package #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think all the partners currently using logging in monitoring are using environmental variables to have the logs come out in JSON format from kit. Changing the names of the keys to have the '=' signs doesn't really make sense in that context, so while this switch to zap will maintain output as it shows up on the CLI, won't it break the json/programatic output mode? |
nikkolasg
approved these changes
Oct 4, 2021
nikkolasg
reviewed
Oct 4, 2021
willscott
suggested changes
Oct 4, 2021
emmanuelm41
force-pushed
the
zap-log-package
branch
from
a3510bc
to
059d198
Compare
emmanuelm41
force-pushed
the
zap-log-package
branch
from
59f37fd
to
faf9c47
Compare
willscott
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.