Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node versioning #824

Merged
merged 26 commits into from
Oct 6, 2021
Merged

Node versioning #824

merged 26 commits into from
Oct 6, 2021

Conversation

emmanuelm41
Copy link
Contributor

No description provided.

@emmanuelm41 emmanuelm41 marked this pull request as draft October 1, 2021 13:39
@emmanuelm41 emmanuelm41 force-pushed the node-versioning branch 2 times, most recently from 953eac2 to f2420a4 Compare October 1, 2021 13:47
Copy link
Collaborator

@nikkolasg nikkolasg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - See my comments, I think this may be overkill here but I would like to hear why you think this was the best way forward ! (and also @willscott 's opinion on the matter is more than welcomed).

chain/beacon/node.go Show resolved Hide resolved
core/broadcast.go Outdated Show resolved Hide resolved
core/drand.go Show resolved Hide resolved
protobuf/crypto/dkg/dkg.proto Outdated Show resolved Hide resolved
core/drand_interceptors.go Show resolved Hide resolved
utils/version.go Outdated Show resolved Hide resolved
Copy link
Member

@willscott willscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this approach. no objection to this structure of tagging every message.

Dockerfile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
common/constants.go Show resolved Hide resolved
protobuf/common/context.go Outdated Show resolved Hide resolved
utils/version.go Outdated Show resolved Hide resolved
@emmanuelm41 emmanuelm41 marked this pull request as ready for review October 5, 2021 17:53
Copy link
Member

@willscott willscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One ask for the github workflow

.github/workflows/release.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@nikkolasg nikkolasg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikkolasg nikkolasg merged commit 8a3dece into drand:master Oct 6, 2021
@emmanuelm41 emmanuelm41 deleted the node-versioning branch October 6, 2021 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants