Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test improvements #828

Merged
merged 28 commits into from
Oct 13, 2021
Merged

Test improvements #828

merged 28 commits into from
Oct 13, 2021

Conversation

emmanuelm41
Copy link
Contributor

No description provided.

@emmanuelm41 emmanuelm41 marked this pull request as ready for review October 6, 2021 14:27
@emmanuelm41 emmanuelm41 marked this pull request as draft October 6, 2021 14:27
@emmanuelm41 emmanuelm41 marked this pull request as ready for review October 11, 2021 12:49
client/http/utils_test.go Outdated Show resolved Hide resolved
http/utils_test.go Outdated Show resolved Hide resolved
@nikkolasg
Copy link
Collaborator

Is the test passing reliably now or because you ran it multiple times ?

@emmanuelm41
Copy link
Contributor Author

Is the test passing reliably now or because you ran it multiple times ?

Tests here get better, but they are still failing some times.

client/http/http_test.go Outdated Show resolved Hide resolved
@willscott willscott merged commit 6fe4c2f into drand:master Oct 13, 2021
@emmanuelm41 emmanuelm41 deleted the test-improvements branch October 13, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants