Add JSON logger option #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go version update
willscott
reviewed
Oct 8, 2021
cmd/client/main.go
Outdated
| @@ -63,6 +63,11 @@ var clientMetricsIDFlag = &cli.StringFlag{ | |||
| Usage: "Unique identifier for the client instance, used by the metrics system.", | |||
| } | |||
|
|
|||
| var jsonFlag = &cli.BoolFlag{ | |||
There was a problem hiding this comment.
you need to add this to app.Flags on line 82 if you want it to be usable in this command
There was a problem hiding this comment.
Thanks for that! I didn't notice.
|
|
||
| core := zapcore.NewCore(encoder, output, zapcore.Level(level)) | ||
| func getConsoleEncoder() zapcore.Encoder { |
There was a problem hiding this comment.
json encoder and console encoder here appear to be the same. is there a reason we don't have the getConsoleEconder return zapcore.NewConsoleEncoder rather than NewJSONEncoder?
There was a problem hiding this comment.
Thanks again here! I made a mistake.
willscott
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.