Minor improvements #831
Merged
Minor improvements #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go version update
nikkolasg
reviewed
Oct 14, 2021
nikkolasg
reviewed
Oct 14, 2021
|
|
||
| // WithSchemeID | ||
| // WithSchemeID allows user to set a scheme using its ID. The scheme | ||
| // is used to customize some behaviors inside the client | ||
| func WithSchemeID(schID string) Option { |
There was a problem hiding this comment.
Wait now I realize that we miss something here: there should be a way for the client to automatically fetch the ID from the endpoint so we dont need to give it as option. That's how it works currently for the public key / genesis hash. Can you add that in a subsequent PR as a TODO item ?
There was a problem hiding this comment.
I will add a TODO for this. Could you explain me which are the options a client has to work? Using chainInfo file is the first one. Which are the other ones?
nikkolasg
reviewed
Oct 14, 2021
willscott
reviewed
Oct 15, 2021
|
@willscott Let's merge it then! |
willscott
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.