-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scripts for client and relay working environments on docker #844
Conversation
a296d3e
to
a57423d
Compare
@@ -81,3 +81,30 @@ services: | |||
DRAND_PUBLIC_ADDRESS: "drand_4:8480" | |||
DRAND_SHARE_SECRET: "thisisthesecretweshouldsettorundkgprocessonthenodes" | |||
|
|||
drand_client: | |||
container_name: drand_client | |||
image: docker.io/drandorg/go-drand-dev:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will we need to set up a repo / publish this?
(there's some extra devops code that needs to exist somewhere to do that if so)
I guess the makefile build will make that image available under that name locally, so that may be enough.
I think the ask then is to add a readme in test/docker
explaining what needs to happen to run these tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@willscott it is done. Could you please check it?
e24bc63
to
a7e6c8f
Compare
Can we have a quick description of what differs from https://github.com/drand/drand/blob/master/docker/docker-compose.yml and in which purposes ? Both seem to spawn docker images as well for testing. Why not using that ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the code originated from docker/ is now moved for tests as was intended to.
docker/ folder is only use now by the toproot dockerfile. The rest is here for testing purpose for relay and client (which the previous code in docker/ was not testing).
This tags images as |
No description provided.