Feat/log catchup

[nikkolasg]

No description provided.

[willscott]

confirming this is a forward-port of commits made to the release branch?

[nikkolasg]

Yes that is the same branch I resuscitated and made the PR against master. I was also afraid of the commits versions bumps etc but only these two files are changed :) Le mar. 14 déc. 2021 à 09:06, Will ***@***.***> a écrit :

…

confirming this is a forward-port of commits made to the release branch? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#877 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AATSFC62HWAHU65TGNPP5WDUQ4CJXANCNFSM5KAJ2TKA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- Nicolas Gailly

[nikkolasg]

Is this the same bug than usual that we should still fix or stg else ?

2021-11-30T21:34:42.2678281Z ==================
2021-11-30T21:34:42.2678686Z WARNING: DATA RACE
2021-11-30T21:34:42.2679217Z Write at 0x00c00039e580 by goroutine 10:
2021-11-30T21:34:42.2679979Z   github.com/drand/drand/test/mock.(*Server).PublicRandStream()
2021-11-30T21:34:42.2681277Z       /home/runner/work/drand/drand/test/mock/grpcserver.go:81 +0x84
2021-11-30T21:34:42.2682098Z   github.com/drand/drand/core.(*drandProxy).Watch.func1()
2021-11-30T21:34:42.2682938Z       /home/runner/work/drand/drand/core/drand_proxy.go:50 +0xba
2021-11-30T21:34:42.2683389Z 
2021-11-30T21:34:42.2683895Z Previous read at 0x00c00039e580 by goroutine 82:
2021-11-30T21:34:42.2684695Z   github.com/drand/drand/test/mock.(*Server).PublicRandStream()
2021-11-30T21:34:42.2685618Z       /home/runner/work/drand/drand/test/mock/grpcserver.go:85 +0x11e
2021-11-30T21:34:42.2686446Z   github.com/drand/drand/core.(*drandProxy).Watch.func1()
2021-11-30T21:34:42.2688138Z       /home/runner/work/drand/drand/core/drand_proxy.go:50 +0xba
2021-11-30T21:34:42.2689240Z 
2021-11-30T21:34:42.2689731Z Goroutine 10 (running) created at:
2021-11-30T21:34:42.2690404Z   github.com/drand/drand/core.(*drandProxy).Watch()
2021-11-30T21:34:42.2691203Z       /home/runner/work/drand/drand/core/drand_proxy.go:49 +0x19c
2021-11-30T21:34:42.2692035Z   github.com/drand/drand/http.(*handler).watchWithTimeout()
2021-11-30T21:34:42.2692892Z       /home/runner/work/drand/drand/http/server.go:116 +0xe1
2021-11-30T21:34:42.2693587Z   github.com/drand/drand/http.(*handler).Watch()
2021-11-30T21:34:42.2694550Z       /home/runner/work/drand/drand/http/server.go:109 +0x4c
2021-11-30T21:34:42.2695790Z   github.com/drand/drand/http.(*handler).start·dwrap·2()
2021-11-30T21:34:42.2696610Z       /home/runner/work/drand/drand/http/server.go:98 +0x64
2021-11-30T21:34:42.2697021Z 
2021-11-30T21:34:42.2697493Z Goroutine 82 (running) created at:
2021-11-30T21:34:42.2698165Z   github.com/drand/drand/core.(*drandProxy).Watch()
2021-11-30T21:34:42.2698954Z       /home/runner/work/drand/drand/core/drand_proxy.go:49 +0x19c
2021-11-30T21:34:42.2699749Z   github.com/drand/drand/http.(*handler).watchWithTimeout()
2021-11-30T21:34:42.2700595Z       /home/runner/work/drand/drand/http/server.go:116 +0xe1
2021-11-30T21:34:42.2701299Z   github.com/drand/drand/http.(*handler).Watch()
2021-11-30T21:34:42.2702082Z       /home/runner/work/drand/drand/http/server.go:109 +0x4c
2021-11-30T21:34:42.2703064Z   github.com/drand/drand/http.(*handler).start·dwrap·2()
2021-11-30T21:34:42.2703875Z       /home/runner/work/drand/drand/http/server.go:98 +0x64
2021-11-30T21:34:42.2704439Z ==================
2021-11-30T21:34:42.2705022Z     testing.go:1152: race detected during execution of test
2021-11-30T21:34:42.2706422Z --- FAIL: TestHTTPWatch (2.04s)

[willscott]

I believe that's fixed by a subsequent commit on the release branch

[AnomalRoil]

Do you still want to include this @nikkolasg?
I expect that a rebase against master would solve the coverage test issue.