Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save prev signature on db only if chained mode is enabled #895

Merged
merged 9 commits into from
Jan 11, 2022
Merged

Save prev signature on db only if chained mode is enabled #895

merged 9 commits into from
Jan 11, 2022

Conversation

emmanuelm41
Copy link
Contributor

No description provided.

nikkolasg
nikkolasg reviewed Jan 4, 2022
View reviewed changes
Copy link
Collaborator

@nikkolasg nikkolasg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that looks good to me!! I think to merge this we need some comments and a test that checks if the scheme store works properly AND that the database really gives back beacons with nil PreviousSig field if it is unchained. Nice !!

chain/beacon/chain.go Outdated Show resolved Hide resolved
chain/beacon/store.go Show resolved Hide resolved
nikkolasg
nikkolasg reviewed Jan 4, 2022
View reviewed changes
chain/beacon/chain.go Outdated Show resolved Hide resolved
@emmanuelm41
Copy link
Contributor Author

Yes that looks good to me!! I think to merge this we need some comments and a test that checks if the scheme store works properly AND that the database really gives back beacons with nil PreviousSig field if it is unchained. Nice !!

I added one test. Could you check it now?

@emmanuelm41 emmanuelm41 merged commit dd45899 into drand:master Jan 11, 2022
@emmanuelm41 emmanuelm41 deleted the unchained-sig-fixes branch January 11, 2022 12:10
@nikkolasg nikkolasg mentioned this pull request Jan 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikkolasg nikkolasg nikkolasg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emmanuelm41 @nikkolasg