Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump kyber latest 1.1.9 #896

Merged
merged 1 commit into from
Jan 11, 2022
Merged

bump kyber latest 1.1.9 #896

merged 1 commit into from
Jan 11, 2022

Conversation

nikkolasg
Copy link
Collaborator

No description provided.

@willscott
Copy link
Member

should we also cherrypick this to the v0.3 branch?

@nikkolasg
Copy link
Collaborator Author

I dont think it's needed to cherry pick this on 0.3, the fix on kyber on the indices is already there that is what is important?

@willscott
Copy link
Member

v0.3.x branch does not have the 1.1.8 version of kyber you released earlier today yet. Do you mean to say we shouldn't back-port the logging changes when we do that?

@nikkolasg
Copy link
Collaborator Author

  • 1.1.8 was released to early, my bad, I made a better logging feature on 1.1.9 which is the one we should use (i deleted the 1.1.8 release)
  • If you think it is necessary we can integrate the logging changes but I don't see that as necessary right now... wdyt ?

@willscott
Copy link
Member

I'm pointing out this is pulling in the v1.1.9 (and 1.1.8 kyber changes to master). In addition we should update the v1.3.0 branch in drand to use the newer version of kyber, since I believe that it will be the v1.3.x branch that we intend to have LoE use in their next round of ceremonies, not also the multibeacon work that has landed in master.

@nikkolasg nikkolasg merged commit 105ea6f into master Jan 11, 2022
@nikkolasg nikkolasg deleted the feat/dkg-log branch January 11, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants