Fix bug on reshare process #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmanuelm41
force-pushed
the
fix-reshare-bug
branch
from
665c3b4
to
a736ef4
Compare
|
Great catch! Do you have a solution to the bug? I guess a straightforward one is to avoid triggering the DKG if either of the 'beacon id' or the '--id' flag do not match what has been expected - in this case the '--id' flag of the right network is missing. |
emmanuelm41
force-pushed
the
fix-reshare-bug
branch
from
f34c381
to
a28a800
Compare
The fix is in the PR. Server will compare beacon id on InitReshare request and on old group file. They should be the same in order to continue. If they are different, we won't accept the request. |
nikkolasg
approved these changes
Jan 11, 2022
willscott
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This bug allows a user to init a reshape process with a difference between the beacon id he sets on CLI command and the ones present inside config file.
Explanation
Two networks are working inside the nodes: the default and a second one. We start a reshare on the second one to add a new node to this network. This new node uses the flag
--fromon CLI reshare cmd, but the user forgets to set the--idflag. The new node which is being added to the network uses the default one as the "resharing beacon process" instead of the second one. When it tries to send its share to the leader node, it uses the beacon id present on the old config file (it is the correct one). For that reason the leader is able to start the dkg process... as a result, the new node is not on the new group file. In some cases, this scenario triggered an existing kyber bug.