Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing logs #921

Merged
merged 5 commits into from
Mar 24, 2022
Merged

Fixing logs #921

merged 5 commits into from
Mar 24, 2022

Conversation

AnomalRoil
Copy link
Member

Backport from master, see #920

chain/beacon/node.go Outdated Show resolved Hide resolved
chain/beacon/node.go Outdated Show resolved Hide resolved
@AnomalRoil
Copy link
Member Author

@willscott @nikkolasg The release 1.3 branch seems to have some issues with its tests, 6405db0 was already not passing.
Should we go ahead and merge this or should I spend time trying to patch the tests on this old release?

@willscott
Copy link
Member

  • the 1.3 branch is where current logs are coming from.
  • it uses a different logger from what's in master. worth testing manually the change and making sure you get output as expected from the changed lines
  • assuming it's just a flaky test, i think it's fine not to spend the effort back-porting the test fix-up to the branch

@nikkolasg
Copy link
Collaborator

I am merging it because this is only changing logs and we need to advance on this - the flaky tests were already present before this change anyway.

@nikkolasg nikkolasg merged commit d078b6b into release/v1.3 Mar 24, 2022
@nikkolasg nikkolasg deleted the log/fixkv branch March 24, 2022 13:35
@yiannisbot yiannisbot added this to the Fixing Tests & CI milestone Apr 1, 2022
@yiannisbot yiannisbot added the testing Area: Testing label Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Area: Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants