[Cleanup] Avoid leaking deferred calls #931
Conversation
| } | ||
| // Using an anonymous function to not leak the defer | ||
| er = func() error { | ||
| store, err := boltdb.NewBoltStore(path.Join(storePath, core.DefaultDBFolder), conf.BoltOptions()) |
There was a problem hiding this comment.
is it safe to make multiple bolt stores here? i'd prefer just one store so we don't potentially have multiple things attempting to open the same on-disk storage
There was a problem hiding this comment.
My understanding is that these are all accessing different DBs: one for each "beaconID", so it should be fine. (It's part of these new "multi-beacon/multi-frequency" features).
So as I understand it we are storing each "beacon DB" in its own store instead of mashing them all in the same DB.
|
So, I'm now pretty happy with how it works both locally and on the CI, so I consider merging it even if codecov complains we've reduced our coverage since we don't hit a error case anymore during the tests... |
We had deferred calls that were issued in a for loop, and as such were "leaking".
This PR wraps the deferred calls and code into anonymous function, which means that the deferred calls are run at the end of each iteration instead of leaking until the end of the function execution.