Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add drand_version and drand_build_time metrics #942

Merged
merged 9 commits into from
Mar 30, 2022
Merged

Add drand_version and drand_build_time metrics #942

merged 9 commits into from
Mar 30, 2022

Conversation

mcamou
Copy link
Contributor

@mcamou mcamou commented Mar 29, 2022

No description provided.

@mcamou mcamou self-assigned this Mar 29, 2022
@mcamou mcamou added the monitoring Area: Monitoring label Mar 29, 2022
@mcamou mcamou mentioned this pull request Mar 29, 2022
Closed
AnomalRoil
AnomalRoil requested changes Mar 29, 2022
View reviewed changes
.tool-versions Outdated Show resolved Hide resolved
metrics/metrics.go Outdated Show resolved Hide resolved
common/constants.go Outdated Show resolved Hide resolved
@mcamou mcamou force-pushed the metrics branch 4 times, most recently from 86577f4 to 54e8998 Compare March 29, 2022 18:42
@mcamou
Copy link
Contributor Author

mcamou commented Mar 29, 2022

Any ideas how to fix the coverage? I can't seem to get the coverage test to pass.

willscott
willscott reviewed Mar 29, 2022
View reviewed changes
metrics/metrics_test.go Outdated Show resolved Hide resolved
willscott
willscott reviewed Mar 29, 2022
View reviewed changes
metrics/metrics.go Outdated Show resolved Hide resolved
@willscott
Copy link
Member

Any ideas how to fix the coverage? I can't seem to get the coverage test to pass.

re-running it seems to have made things pass as far as I can see from CI

AnomalRoil
AnomalRoil approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@AnomalRoil AnomalRoil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to rebase in order to sign your commits so that they would be verified:
git pull && git rebase --exec 'git commit --amend --no-edit -n -S' -i HEAD~10

@mcamou mcamou merged commit 22e77d2 into master Mar 30, 2022
@mcamou mcamou deleted the metrics branch March 30, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willscott willscott willscott approved these changes

@AnomalRoil AnomalRoil AnomalRoil approved these changes

@hsanjuan hsanjuan Awaiting requested review from hsanjuan

@nikkolasg nikkolasg Awaiting requested review from nikkolasg nikkolasg is a code owner

Assignees

@mcamou mcamou

Labels
monitoring Area: Monitoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mcamou @willscott @AnomalRoil