Remove drand_version metric #945
Conversation
mcamou
force-pushed
the
metrics
branch
2 times, most recently
from
2de8faa
to
e947938
Compare
mcamou
changed the title
|
After creating the dashboard I realized that we don't even need to convert the version to a number if we add it as a label in |
|
Related: #939 |
metrics/metrics.go
Outdated
| ConstLabels: map[string]string{"build": common.COMMIT}, | ||
| }, func() float64 { return float64(getVersionNum(common.GetAppVersion())) }) | ||
| // DKGStateChangeTimestamp tracks DKG status changes | ||
| DKGStateChangeTimestamp = prometheus.NewGaugeVec(prometheus.GaugeOpts{ |
There was a problem hiding this comment.
is it expected that nothing is going to report this metric?
There was a problem hiding this comment.
ARGH. I'd stashed that before the first commit then unstashed and forgot to restash before the second one. It's part of the next thing to implement. I've removed it and force-pushed.
mcamou
force-pushed
the
metrics
branch
2 times, most recently
from
66b49b5
to
8f5c689
Compare
| DrandBuildTime = prometheus.NewUntypedFunc(prometheus.UntypedOpts{ | ||
| Name: "drand_build_time", | ||
| Help: "Timestamp when the binary was built in seconds since the Epoch", |
There was a problem hiding this comment.
This might need to be rephrased / renamed if it's also responsible for the version, no?
There was a problem hiding this comment.
The metric name refers to the meaning of the value, which is still the build time. We're using labels to pass additional info, but their meaning is in the label name, not in the metric name.
No description provided.