Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-picking from release/v1.3.0 #958

Merged
merged 7 commits into from
Apr 8, 2022
Merged

Cherry-picking from release/v1.3.0 #958

merged 7 commits into from
Apr 8, 2022

Conversation

AnomalRoil
Copy link
Member

@AnomalRoil AnomalRoil commented Apr 6, 2022

This includes #875, #879 and #880.

It also replaces deprecated Prometheus methods with current ones.

Draft PR for now because WIP, I'll add more commits including more code that needs to be front-ported.

Also replacing deprecated Prometheus methods with current ones
since our current Quic dependencies aren't compiling with Go 1.18
@AnomalRoil AnomalRoil changed the title Front-porting PRs from the release v1.3.0 branch to master Cherry-picking from release/v1.3.0 Apr 7, 2022
@AnomalRoil AnomalRoil marked this pull request as ready for review April 7, 2022 15:22
@AnomalRoil AnomalRoil added the refactoring Kind: Refactoring / Cleanup label Apr 7, 2022
@AnomalRoil AnomalRoil self-assigned this Apr 7, 2022
Copy link
Contributor

@mcamou mcamou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnomalRoil
Copy link
Member Author

Yup, and pinning our GHA to Go 1.17 to avoid issues with our current quic-go dependency not being compatible with Go 1.18

Copy link
Member

@willscott willscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for pulling all of these forward

@AnomalRoil AnomalRoil merged commit 6252dd5 into master Apr 8, 2022
@AnomalRoil AnomalRoil deleted the port/lp2p branch April 8, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Kind: Refactoring / Cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants