Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix burning in the commit ID into the binary #960

Merged
merged 3 commits into from
Apr 7, 2022
Merged

Fix burning in the commit ID into the binary #960

merged 3 commits into from
Apr 7, 2022

Conversation

mcamou
Copy link
Contributor

@mcamou mcamou commented Apr 7, 2022

No description provided.

@mcamou mcamou self-assigned this Apr 7, 2022
@mcamou mcamou added the monitoring Area: Monitoring label Apr 7, 2022
@mcamou mcamou added this to the Ceremony dashboard milestone Apr 7, 2022
@AnomalRoil
Copy link
Member

Could you please also include this fix?
#956 (comment)

@mcamou
Copy link
Contributor Author

mcamou commented Apr 7, 2022

Could you please also include this fix? #956 (comment)

Done, and sorry about that

@mcamou
Copy link
Contributor Author

mcamou commented Apr 7, 2022

@AnomalRoil @willscott I have no idea how to fix the codecov/patch error. It's basically saying that the changed line is not covered by tests (which, granted, it isn't, but I'm not sure of the benefit of actually adding a test to exercise that line).

@willscott
Copy link
Member

that's fine - that's just noting that overall code coverage goes down as a result of this change.

@mcamou
Copy link
Contributor Author

mcamou commented Apr 7, 2022 •
edited
Loading

Not sure why it would go down, since the number of Go lines stays the same. Plus, the failing test does not allow me to merge :-(

@willscott
Copy link
Member

I don't think that's true - we don't have codecov as a required test. i'll merge for now

@willscott willscott merged commit 3c0760b into master Apr 7, 2022
@willscott willscott deleted the version branch April 7, 2022 11:10
@mcamou
Copy link
Contributor Author

mcamou commented Apr 7, 2022

Thanks... the "Squash and Merge" button was white for me instead of green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willscott willscott willscott approved these changes

@AnomalRoil AnomalRoil AnomalRoil approved these changes

Assignees

@mcamou mcamou

Labels
monitoring Area: Monitoring
Projects
None yet
Milestone
Ceremony dashboard
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mcamou @AnomalRoil @willscott