Remove the incoming_connection_timestamp metric #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
reviewed
Apr 20, 2022
net/metrics.go
Outdated
| @@ -22,7 +23,9 @@ func (h incomingConnectionsStatsHandler) HandleRPC(ctx context.Context, rpcStats | |||
| } | |||
|
|
|||
| func (h incomingConnectionsStatsHandler) TagConn(ctx context.Context, tagInfo *stats.ConnTagInfo) context.Context { | |||
| metrics.IncomingConnectionTimestamp.WithLabelValues(tagInfo.RemoteAddr.String()).SetToCurrentTime() | |||
| remoteAddr := tagInfo.RemoteAddr.String() | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks for the heads-up. Anyway, I've removed the whole thing. We'll just track outgoing connections.
mcamou
changed the title
AnomalRoil
approved these changes
Apr 20, 2022
willscott
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.