Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong threshold in DKG protocol #43

Closed
si-co opened this issue Dec 6, 2022 · 1 comment · Fixed by #51
Closed

Wrong threshold in DKG protocol #43

si-co opened this issue Dec 6, 2022 · 1 comment · Fixed by #51
Labels
bug Something isn't working

Comments

@si-co
Copy link

si-co commented Dec 6, 2022

In https://github.com/drand/kyber/blob/master/share/dkg/dkg.go#L1095, the threshold should be n/2 + 1 instead of (n+1)/2. This bug likely comes from the DEDIS original VSS implementation (see dedis#374). If the bug is confirmed, I'm happy to submit a PR.
@AnomalRoil
Copy link
Member

@si-co Sorry for not answering earlier! Yes this is a bug that should be corrected, let me know if you plan on sending a PR, otherwise I'll do it at some point in May.

@AnomalRoil AnomalRoil added the bug Something isn't working label Mar 27, 2023
AnomalRoil added a commit that referenced this issue Jun 16, 2023
@AnomalRoil
Closes #43 that was actually already fixed in #45, but this also fixe…
2f669a8 
…s the issue from dedis#374
@AnomalRoil AnomalRoil mentioned this issue Jun 16, 2023
Merged
Robingoumaz pushed a commit to Robingoumaz/kyber-drand that referenced this issue Apr 4, 2024
@AnomalRoil @Robingoumaz
Fix MinimumT everywhere (drand#51)
0ba2d88 
* Closes drand#43 that was actually already fixed in drand#45, but this also fixes the issue from dedis#374

* Adding table tests for MinimumT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix MinimumT everywhere drand/kyber
2 participants
@si-co @AnomalRoil