Fix eviction of absent participant #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
approved these changes
Sep 24, 2020
|
Well Actually lets not merge right now - this fixes the bug we had but it's not fixing it in the case where we dont have fastsync, it's not general enough - I'll refactor the fix tmr |
|
Ready to review |
willscott
approved these changes
Sep 25, 2020
share/dkg/dkg.go
Outdated
| // we only need to look at the nodes that did not sent any response, | ||
| // since the invalid one are already markes as evicted | ||
| allSent := append(validAuthors, d.evictedHolders...) | ||
| isPresent := isEvicted |
There was a problem hiding this comment.
this is counter-intuitive. from what i can see, this method is only used in this if block. can you directly call 'isEvicted' in the loop below. Renaming it to a variable named the inverse property makes it more confusing what is being checked.
Robingoumaz
pushed a commit
to Robingoumaz/kyber-drand
that referenced
this pull request
Apr 4, 2024
* test + correction on fast sync * removing useless test * adapted to general case * better function name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to drand/drand#752