-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark all fields touched #8
Comments
Thanks for raising this Bernard - and the associated PR. It's now the weekend for me (I'm in Sydney, Australia) so I won't do anything with the PR until Monday (so I can check the branch out and test it out). I've had a quick look and it looks good though so shouldn't be a problem to merge This is definitely a good feature to add so I'm very happy that you've identified the issue and raised a PR for it - I'm really very grateful, thanks! 👍 |
This feature got broken again. It was fixed in |
Thanks for reporting this @blabno - is it still broken in 0.0.28 ? There have been subsequent changes to validation since that commit you referenced. I have been trying to ensure we have unit tests to cover all the conditions but it might be that we have a shortfall in the tests. |
Yes, it exists in 28 as well.
Sent from ProtonMail mobile
…-------- Original Message --------
On 27 Nov 2018, 01:29, Dave Draper wrote:
Thanks for reporting this ***@***.***(https://github.com/blabno) - is it still broken in 0.0.28 ? There have been subsequent changes to validation since that commit you referenced.
I have been trying to ensure we have unit tests to cover all the conditions but it might be that we have a shortfall in the tests.
—
You are receiving this because you were mentioned.
Reply to this email directly, [view it on GitHub](#8 (comment)), or [mute the thread](https://github.com/notifications/unsubscribe-auth/AAaT2PP01bpYMN8sJCcHKlhDVZlLh8RQks5uzIeBgaJpZM4XtRfU).
|
OK, apologies for the slow response on this - I should be able to look at this next week. |
When I submit the form and validation is failing I want all validation errors to be shown.
So it would be great to tell the form to mark every field as touched.
The text was updated successfully, but these errors were encountered: