Add #decorated? method to Draper::CollectionDecorator

[carloslopes]

Hi,

when i want to check if an object is decorated i call #decorated? and it will inform me. This is really useful when testing.

But when i have a Draper::CollectionDecorator i can't do this.

What do you think about add the #decorated? method on collections too?

If you think this useful, i can try to make it works.

[haines]

I do like as many things as possible to be similar between the collection decorators and the regular decorators!

The one problem is that for a decorator, we can have decorated? return true, and for anything that includes Decoratable (ie models) decorated? returns false, so it works quite nicely:

model.decorated? # => false
Decorator.new(model).decorated? # => true

Unfortunately for a collection decorator, we don't have a way of implementing a decorated? method for the source object.

[].decorated? # => NoMethodError
CollectionDecorator.new([]).decorated? # => true

I don't think the method is as useful without its counterpart. However, I'm not completely opposed to adding it, because if you write a spec like

expect(products).to be_decorated

it will still fail when the subject is not decorated, although less gracefully!

[carloslopes]

hm yes.

i think that in this case it will not be a problem if the source object doesn't have the #decorated? method, because this will be more useful for tests.

Does this have a chance to be merged if i do it?

[haines]

I would give it a 👍 - @steveklabnik?

[steveklabnik]

Yeah, seems fine to me. The test case is compelling.