Extract helper proxy

[haines]

Pulling more stuff out of Decorator...

[nashby]

not sure that helpers method should be memoized. @steveklabnik, there was an issue with it, wasn't it?

[haines]

Actually, as of e2a757d we are memoizing the view context. This, on the other hand, only memoizes the HelperProxy object, and HelperProxy#view_context delegates to Draper::ViewContext.current, so I think this is safer.

[steveklabnik]

Right. I'm really just not sure what all this effects. We really need some real-world integration tests :/

[steveklabnik]

That said, this seems fine for now. I just have overall concerns.

[haines]

@steveklabnik Understood! As I mentioned, I think what I did here is the "most safe" memoization.

I'll take a look at integration testing too.

[steveklabnik]

I pushed a branch, but it's not quite working yet. Check it out.

On Monday, October 15, 2012, Andrew Haines wrote:

@steveklabnik https://github.com/steveklabnik Understood! As I
mentioned, I think what I did here is the "most safe" memoization.

I'll take a look at integration testing too.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/310#issuecomment-9461226.