Document how to stub route helper functions in isolated tests. Addresses... #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| helpers.stubs(users_path: '/users') | ||
| ``` | ||
|
|
||
|
|
There was a problem hiding this comment.
You're saying to cut the extra newline, correct? Just want to check my emoji interpretation :) 🌵 🎩
|
Seems great with those two minor edits. ❤️ ❤️ 💖 |
|
It should be noted that the |
👍 I think it would be better to use RSpec's syntax here, not that it makes much difference :) |
* Get rid of an unnecessary newline * Change 'include Rails' to 'require Rails' * Clarify when you would need to explicitly include ViewHelpers * Switch from mocha `stubs` to RSpec `stub`
|
👍 ❤️ |
steveklabnik
added a commit
that referenced
this pull request
Apr 5, 2013
Document how to stub route helper functions in isolated tests. Addresses...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... #506.
See the discussion in #506 about the issue this is addressing.
I'm happy to revise this however to best fit into the existing documentation. I'm also not entirely clear if this is a minitest specific thing or if it affects rspec as well. I'd also be fine with changing from mocha's
stubsin the example to rspec'sstubif readers of this documentation are more likely to be familiar with rspec's stubbing stuff.I'm also cool with moving this to the wiki somewhere if this doesn't belong in the README.
Basically tell me how to change this and i'll be glad to do it :)