Fix the indeterminate test issue. #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was due to a couple describe blocks not matching the definition in . Since their name didn't match, wasn't getting included in the minitest-specs. Since the teardown didn't exist, the view context leaked to the next tests to be ran.
|
WTF... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes the indeterminate test issue causing builds to fail randomly. I finally got to the bottom of what was causing it. The issue was with the minitest spec tests. A couple of the
describeblocks didn't have the word "decorator" in them. This prevented minitest from registering the spec type asDraper::TestCase. Since the tests weren't registered as aDraper::TestCase, it wasn't includingDraper::TestCase::ViewContextTeardownwhich definesteardownto clear the view context. Since the view context wasn't being cleared after these tests, the next test that called a helper onViewContext.currentblew up.Testing
Once merged, we should not longer see builds fail randomly. You can test locally by:
$ cd spec/dummySEED=8910 rakeshould fail repeatedly on master.To-Dos
None
References