Clean view context when controller changes #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we reassign controller it is the right thing to do to clear current view context stored in request store. Consider a case when view context was built before the request was made (usage of `h` helper in class level context). View context is built from default controller and has no information about the request. During first request `Draper::ViewContext.current.controller` will be different than `Draper::ViewContext.controller`.
|
Fix for failure can be found here: #800 |
codebycliff
approved these changes
May 8, 2017
codebycliff
added a commit
to codebycliff/draper
that referenced
this pull request
May 8, 2017
codebycliff
added a commit
that referenced
this pull request
May 8, 2017
* Release 3.0.0 * Add breaking change #768 to changelog. * Add recently merged changes to the changelog. * Add configuration and custom default controller to the changelog. * Add entry to changelog for pull request 720 * Add entry to changelog for Rails 5 API-only support. * Add changelog entry for pull request #795. * Add changelog entry for pull request #796. * Add changelog entry for enumerable optimization. * Update maintainer information in README. * Add pull request #799 to changelog. * Add compatability documentation to readme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we reassign controller it is the right thing to do to clear current view context stored in request store. Consider a case when view context was built before the request was made (usage of
hhelper in class level context). View context is built from default controller and has no information about the request. During first requestDraper::ViewContext.current.controllerwill be different thanDraper::ViewContext.controller.Testing
Example Rails app. Use
h.content_tagin class context of some decorator, make this class be eagerly loaded.Perform some request that will execute some decorator to refer to e.g.
request.envvalues that are set up by some middleware (e.g. warden manager).See that
envis missing that key.With that fix, view_context is regenerated when a controller is already available.
To-Dos