Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require action_controller/test_case #856

Conversation

Aesthetikx
Copy link
Contributor

This was initially introduced in 738074f in order to allow draper to work in a rails console session, however this no longer seems necessary.

Requiring this file in non test environments has the consequence of breaking ActionController::Live as discussed in rails issue 31200.

This was initially introduced in
738074f in order to allow draper to
work in a rails console session, however this no longer seems necessary.
Requiring this file in non test environments has the consequence of
breaking ActionController::Live as discussed in rails issue 31200.
@Aesthetikx
Copy link
Contributor Author

Actually, I had not tested this with a decorator using the h helper, and indeed, this does seem to be a required require. Furthermore, this code is only used during rails console and rails runner, so it is not hit during a rails server, unless you have spring running and use a rails console, so this is not as much of a problem as I originally thought, so I am closing this PR.

@Aesthetikx Aesthetikx closed this Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant