Cleanup: Initialize instance variable before use to avoid Ruby warnings #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there! Any news? |
|
Ping @codebycliff |
|
@olleolleolle can you please rebase your branch on master? |
|
I could make an attempt, in about 12 hours. But I can hit the Update Branch button right now. If green, you could Squash commits Into One Commit, using the merge button variant for that. |
|
Haha, the issue is created by: me defining a variable, so the test must be altered to match that new situation! Update: I updated the test, changing it to match the current code. |
- this avoids a Ruby warning
olleolleolle
force-pushed
the
avoid-uninitialized-instance-variable-decorated-collection
branch
from
5431559
to
58b4442
Compare
|
@olleolleolle thank you! Ping @codebycliff |
olleolleolle
changed the title
|
ping @codebycliff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This avoids a Ruby warning emitted on use.
By initializing the variable before use, this is an easy win against the sea of warnings output.
Testing
RUBYOPT=-W2@decorated_collectionis not among the output