Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Rake warning in CI #897

Merged
merged 3 commits into from Jan 21, 2021
Merged

Fix Rake warning in CI #897

merged 3 commits into from Jan 21, 2021

Conversation

n-rodriguez
Copy link
Contributor

@n-rodriguez n-rodriguez commented Jan 14, 2021 •
edited

The rake executable in the rake gem is being loaded, but it's also present in other gems (draper).
Draoer doesn't provide any executable, and if it did, it should go in 'exe' dir.

Fix this warning in CI :

The `rake` executable in the `rake` gem is being loaded, but it's also present in other gems (draper).
If you meant to run the executable for another gem, make sure you use a project specific binstub (`bundle binstub <gem_name>`).
If you plan to use multiple conflicting executables, generate binstubs for them and disambiguate their names.

@n-rodriguez n-rodriguez mentioned this pull request Jan 14, 2021
Merged
@n-rodriguez
Fix Rake warning in CI
155b899 
The `rake` executable in the `rake` gem is being loaded, but it's also present in other gems (draper).
Draoer doesn't provide any executable, and if it did, it should go in
'exe' dir.
@n-rodriguez
Fix RSpec warning
b9e13bc
@n-rodriguez
Use require_relative in gemspec
91cdebc
@n-rodriguez
Copy link
Contributor Author

ping @codebycliff

@n-rodriguez
Copy link
Contributor Author

Ping @codebycliff

@n-rodriguez
Copy link
Contributor Author

Hi there! Any news? @codebycliff

@n-rodriguez
Copy link
Contributor Author

ping @codebycliff I'd like to see this merged before working on Ruby 3 compat.

@n-rodriguez n-rodriguez mentioned this pull request Jan 21, 2021
Open
codebycliff
codebycliff approved these changes Jan 21, 2021
View reviewed changes
Copy link
Collaborator

@codebycliff codebycliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay again.

@codebycliff codebycliff merged commit da6cd97 into drapergem:master Jan 21, 2021
@n-rodriguez n-rodriguez deleted the wip/rake branch January 21, 2021 20:14
@n-rodriguez
Copy link
Contributor Author

@codebycliff thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebycliff codebycliff codebycliff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@n-rodriguez @codebycliff