Improved integration with Global ID #928
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementing `Decorator.find` improves compatibility with Global ID and allows one to use decorated objects in jobs seamlessly. Resolves drapergem#663. Improves drapergem#817.
Alexander-Senko
force-pushed
the
global_id
branch
from
232c68f
to
5b647d2
Compare
Alexander-Senko
added a commit
to Alexander-Senko/draper
that referenced
this pull request
Feb 6, 2024
Overriding defaults for Turbo broadcast jobs allows one to get decorated objects in model partials by default. Resolves drapergem#910. Requires drapergem#928.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementing
Decorator.findimproves compatibility with Global ID and allows one to use decorated objects in background jobs seamlessly.Testing
To-Dos
References