Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to the retrieving model results in wp #83

Open
fortunac opened this issue Oct 8, 2019 · 0 comments
Open

Updates to the retrieving model results in wp #83

fortunac opened this issue Oct 8, 2019 · 0 comments
Labels
WP Involves the Weakest Precondition computation

Comments

@fortunac
Copy link

fortunac commented Oct 8, 2019

  • We should refactor getting a model from the solver to it's own function as there are instances of
 let model = Z3.Solver.get_model solver
              |> Option.value_exn ?here:None ?error:None ?message:None

in constraint.ml, output.ml, precondition.ml, and test_precondition.ml. We should also add a more useful error message for the failure case.

  • When returning the result of SAT or UNSAT, in
    let check ?refute:(refute = true) (solver : Z3.Solver.solver) (ctx : Z3.context)

    we should return either UNSAT or SAT with a model atomically, possibly by creating our own data type that would mirror an option.
@fortunac fortunac added the WP Involves the Weakest Precondition computation label Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WP Involves the Weakest Precondition computation
Projects
None yet
Development

No branches or pull requests

1 participant