Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default url as a config option #84

Closed
ebebbington opened this issue Aug 12, 2021 · 0 comments · Fixed by #82
Closed

Remove default url as a config option #84

ebebbington opened this issue Aug 12, 2021 · 0 comments · Fixed by #82
Assignees
@ebebbington
Labels
Type: Chore Merging this pull request results in a patch version increment

Comments

@ebebbington
Copy link
Member

It's useless to be honest, it was only added as a startup url, but if you use sinco, you'll want to go to a specific url. Removing this option will also speed up load times slightly, for users and tests which is a very nice win
@ebebbington ebebbington added Type: Chore Merging this pull request results in a patch version increment Priority: Low labels Aug 12, 2021
@ebebbington ebebbington linked a pull request Aug 12, 2021 that will close this issue
chore: Remove default url when creating a headless client #82
Merged
@ebebbington ebebbington self-assigned this Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ebebbington ebebbington

Labels
Type: Chore Merging this pull request results in a patch version increment
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Remove default url when creating a headless client drashland/sinco
1 participant
@ebebbington