Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: 406 thrown for empty string accept header #635

Closed
crookse opened this issue May 14, 2022 · 0 comments · Fixed by #638
Closed

bug: 406 thrown for empty string accept header #635

crookse opened this issue May 14, 2022 · 0 comments · Fixed by #638
Labels
Bug Something isn't working as expected

Comments

@crookse
Copy link
Member

crookse commented May 14, 2022

Was doing benchmarks with autocannon and wrk and received 406s. this was due to the accept header being "" which made the request handler think it had to go through the accept header flow -- returning 406s.

Need to check for empty string before running through the accept header flow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working as expected
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: check for non-empty accept header before performing accept header flow drashland/drash
1 participant
@crookse