-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This commit introduces a main command. The main command is in charge of defining subcommands now. * Line is now Cli * Subcommand options are defined through a key-value pair object * CommandLine has been refactored to handle the restructure
If a main command takes in args, then it can't have subcommands
Refactored the following: * options getting * argument getting * options parsing * argument parsing * help menus * command and subcommand validation
crookse
added
the
Type: Major
Merging this pull request results in a major version increment
label
Dec 2, 2021
ebebbington
approved these changes
Dec 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11
Closes #5
Notes
How to create a CLI
There is something that is bothering me. Right now, to describe an argument, you have to provide an
arguments
object. For example:And when you run it, it outputs the following:
My Cool CLI - My cool description USAGE line [option] line [arg: arg] ARGUMENTS arg + Some description. OPTIONS -h, --help Show this menu. -v, --version Show this CLI's version.
I feel like
arguments
is a weird property name. Maybeargument_descriptions
? I wouldn't saydescriptions
, because theoptions
property also contains descriptions (the value is the description of the option(s)), so it's kind of confusing in that regard. Thoughts though?TODO
Change arguments description object?