chore: Restructure internal code #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ebebbington
commented
Jul 16, 2021
ebebbington
commented
- Uses websockets instead of raw tcp for the firefox client
- Due to this, both clients can use the CDP (chrome devtools protocol), so all logic has been abstracted into a single class
- Reduced complexity due to this, and also reduced code size
ebebbington
added
the
Type: Chore
|
I did something wrong since |
ebebbington
commented
Jul 16, 2021
src/client.ts
Outdated
Comment on lines
307
to
315
| // Because if using firefox and windows, the close on the browser subprocess doesn't actually close the processes | ||
| if (Object.getPrototypeOf(this.constructor).name === "FirefoxClient" && Deno.build.os === "windows") { | ||
| const p = Deno.run({ | ||
| cmd: ["taskkill", "/F", "/IM", "firefox.exe"], | ||
| stdout: "null", | ||
| stderr: "null" | ||
| }) | ||
| await p.status() | ||
| p.close() |
There was a problem hiding this comment.
try:
- removing this
await browser.status()above- see if that fixes the issue
- if not, keep in the above logic and open an issue with deno
|
ready for review :) |
crookse
approved these changes
Aug 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.