Skip to content

Commit

Permalink
Name every net the exact same as the attribute it's in
Browse files Browse the repository at this point in the history
On the plus side, the project now hardens. On the minus, it's definitely
largely optimized out.
  • Loading branch information
dratini0 committed Apr 4, 2023
1 parent d37c55c commit 843ce44
Show file tree
Hide file tree
Showing 2 changed files with 179 additions and 179 deletions.
38 changes: 19 additions & 19 deletions src/pov_display.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@

class EdgeDetect(Elaboratable):
def __init__(self):
self.in_ = Signal()
self.last_in = Signal()
self.out = Signal()
self.in_ = Signal(name="in")
self.last_in = Signal(name="last_in")
self.out = Signal(name="out")

def elaborate(self, platform):
m = Module()
Expand All @@ -18,15 +18,15 @@ def elaborate(self, platform):

class SPI(Elaboratable):
def __init__(self):
self.cs_n = Signal()
self.sck = Signal()
self.mosi = Signal()
self.cs_n = Signal(name="cs_n")
self.sck = Signal(name="sck")
self.mosi = Signal(name="mosi")

self.addr = Signal(8)
self.data = Signal(8)
self.we = Signal()
self.addr = Signal(8, name="addr")
self.data = Signal(8, name="data")
self.we = Signal(name="we")

self.bit_index = Signal(3)
self.bit_index = Signal(3, name="bit_index")

self.sck_edge = EdgeDetect()

Expand All @@ -50,8 +50,8 @@ def elaborate(self, platform):

class Controller(Elaboratable):
def __init__(self):
self.hall_in = Signal()
self.addr = Signal(8)
self.hall_in = Signal(name="hall_in")
self.addr = Signal(8, name="addr")

def elaborate(self, platform):
m = Module()
Expand All @@ -61,11 +61,11 @@ def elaborate(self, platform):

class PovDisplay(Elaboratable):
def __init__(self):
self.cs_n = Signal()
self.sck = Signal()
self.mosi = Signal()
self.hall_in = Signal()
self.leds = Signal(8)
self.cs_n = Signal(name="cs_n")
self.sck = Signal(name="sck")
self.mosi = Signal(name="mosi")
self.hall_in = Signal(name="hall_in")
self.leds = Signal(8, name="leds")

self.mem = Memory(width=8, depth=32, init=[])
self.spi = SPI()
Expand Down Expand Up @@ -98,8 +98,8 @@ def elaborate(self, platform):
class PovDisplayWrapper(Elaboratable):
"""The top level, responsible for pinout definition"""
def __init__(self):
self.io_in = Signal(8)
self.io_out = Signal(8)
self.io_in = Signal(8, name="io_in")
self.io_out = Signal(8, name="io_out")
self.display = PovDisplay()

def elaborate(self, platform):
Expand Down

0 comments on commit 843ce44

Please sign in to comment.