Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issues.js checkDefault and Table default bug #89

Closed
wants to merge 4 commits into from
Closed

fix issues.js checkDefault and Table default bug #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3cb37be
fix issues.js checkDefault bug
rainbow401 May 4, 2024
e4940f9
fix table default value bug
rainbow401 May 4, 2024
942c018
Update Table.jsx
rainbow401 May 4, 2024
22bfa7c
Update astToDiagram.js
rainbow401 May 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/components/EditorCanvas/Table.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,11 @@ export default function Table(props) {
</div>
</div>
{tableData.fields.map((e, i) => {

if (e.default.name && e.default.name[0].value && e.default.name[0].value === 'CURRENT_TIMESTAMP') {
e.default = 'CURRENT_TIMESTAMP'
}

return settings.showFieldSummary ? (
<Popover
key={i}
Expand Down
4 changes: 3 additions & 1 deletion src/utils/issues.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ function checkDefault(field) {

if (isFunction(field.default)) return true;

if (Array.isArray(field.default.name)) return true;

if (!field.notNull && field.default.toLowerCase() === "null") return true;

switch (field.type) {
Expand Down Expand Up @@ -124,7 +126,7 @@ export function getIssues(diagram) {
);
}

if (field.notNull && field.default.toLowerCase() === "null") {
if (field.notNull && !Array.isArray(field.default.name) && field.default.toLowerCase() === "null") {
issues.push(
`"${field.name}" field of table "${table.name}" is NOT NULL but has default NULL`,
);
Expand Down