Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed most bugs with inverse modulo and all seg faults #24

Merged
merged 5 commits into from
Feb 11, 2020

Conversation

etiganou
Copy link
Collaborator

No description provided.

@drazioti

This comment has been minimized.

@drazioti
Copy link
Owner

drazioti commented Feb 11, 2020

issued #16 does not resolved. Check onn your own, The same for issue #23

@drazioti
Copy link
Owner

When all the previous solved, please only then send a new pull request.

@etiganou
Copy link
Collaborator Author

Fixed bugs on inverse modulo and P_set

@drazioti
Copy link
Owner

As far as issue #16 I got the same error. Add [WIP] in the title of your pull request.

@etiganou
Copy link
Collaborator Author

I dont have this error anymore

@drazioti
Copy link
Owner

try $git log
My head is in the commit:
commit 76d907f
What do you get?

@etiganou
Copy link
Collaborator Author

This is the last commit the problem should be solved... One commit before that I changed the code in parallel version that caused the problems

@etiganou
Copy link
Collaborator Author

61f1ab9 this solved the problem

@drazioti
Copy link
Owner

drazioti commented Feb 11, 2020

Give me the output from ./a.out 40 39 38 1 1 --ham 15 -b 32 -f 1
this is mine.

H values : 40 39 38 1 1 
Bound : 32
Fragmentation : 1
Lambda is : 124818698712984469023600000000000000000000000000000000000000
hamming   : 15
P size is : 15864
looking for Carmichaels with 15849 factors

density of the problem     : 81.753472

Size of I is : 32
h1 = 7
h2 = 8
Hash Implementation: True


Combination time: 2.547176 seconds

frag = 1

Time for func2 is: 7.742747 seconds
The first set U1, has been stored in memory
Hashtable size : 3365856

Inverted is : 0
Number 3235799124554918962530791759490966796876 doesnt have inverse modulo 124818698712984469023600000000000000000000000000000000000000

@etiganou

This comment has been minimized.

@etiganou
Copy link
Collaborator Author

This input runs correctly on my code

@etiganou
Copy link
Collaborator Author

να κλείσω μήπως αυτό το pull request και να το ξανακάνω ?

@drazioti
Copy link
Owner

The output
Number 3235799124554918962530791759490966796876 doesnt have inverse modulo 124818698712984469023600000000000000000000000000000000000000

is true in the sense that indeed the two numbers have gcd > 1, so there is not an inverse.
This is another type of problem, not accuracy problem.

@drazioti
Copy link
Owner

This input runs correctly on my code

show me the output of ./a.out 40 39 38 1 1 --ham 15 -b 32 -f 1

@drazioti
Copy link
Owner

να κλείσω μήπως αυτό το pull request και να το ξανακάνω ?

no

@etiganou
Copy link
Collaborator Author

Output του παραδείγματος

Screenshot from 2020-02-11 21-10-34

μετα συνεχίζει να τρέχει κανονικά

@etiganou
Copy link
Collaborator Author

Σας λείπει αυτή η γραμμη κώδικα
Screenshot from 2020-02-11 21-14-33

γραμμές 155-157 στο carmi.cpp

@drazioti
Copy link
Owner

drazioti commented Feb 11, 2020

Output του παραδείγματος

Screenshot from 2020-02-11 21-10-34

μετα συνεχίζει να τρέχει κανονικά

why you sent a screenshot? copy and paste the output.Maybe you have to wait a little to see the problem. The problem appears after The U1 has been built.

@drazioti
Copy link
Owner

Σας λείπει αυτή η γραμμη κώδικα
Screenshot from 2020-02-11 21-14-33

γραμμές 155-157 στο carmi.cpp

no I have this line. we run the same code.

@drazioti
Copy link
Owner

drazioti commented Feb 11, 2020

Ok got it. After git reset --hard, seems that things go to the right position.,

@drazioti drazioti merged commit 5fc5f55 into drazioti:master Feb 11, 2020
@drazioti
Copy link
Owner

Only issue #7 remains,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants