Skip to content

Commit

Permalink
For "required" input fields, use browser validation instead of just t…
Browse files Browse the repository at this point in the history
…ext indicator
  • Loading branch information
drbyte committed Jul 1, 2020
1 parent 2ca8bfb commit 233eaa6
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions admin/includes/functions/html_output.php
Expand Up @@ -263,11 +263,12 @@ function zen_draw_input_field($name, $value = '~*~*#', $parameters = '', $requir

if (zen_not_null($parameters)) $field .= ' ' . $parameters;

if ($required && strpos($parameters, 'required') === false) {
$field .= ' required';
}

$field .= ' />';

if ($required && !empty(TEXT_FIELD_REQUIRED)) {
$field .= '&nbsp;<span class="alert">' . TEXT_FIELD_REQUIRED . '</span>';
}
return $field;
}

Expand Down Expand Up @@ -371,13 +372,16 @@ function zen_draw_hidden_field($name, $value = '~*~*#', $parameters = '') {
* @return string
*/
function zen_draw_pull_down_menu($name, $values, $default = '', $parameters = '', $required = false) {
// $field = '<select name="' . zen_output_string($name) . '"';
$field = '<select rel="dropdown" name="' . zen_output_string($name) . '"';

if (zen_not_null($parameters)) {
$field .= ' ' . $parameters;
}

if ($required && strpos($parameters, 'required') === false) {
$field .= ' required';
}

$field .= '>' . "\n";

if (empty($default) && isset($GLOBALS[$name]) && is_string($GLOBALS[$name])) {
Expand All @@ -394,10 +398,6 @@ function zen_draw_pull_down_menu($name, $values, $default = '', $parameters = ''
}
$field .= '</select>' . "\n";

if ($required == true) {
$field .= TEXT_FIELD_REQUIRED;
}

return $field;
}

Expand Down

0 comments on commit 233eaa6

Please sign in to comment.