Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate the ssh key using the cryptography module #303

Merged
merged 6 commits into from Apr 10, 2018

Commits on Apr 10, 2018

  1. Generate the ssh key using the cryptography module

    This is better because ssh-keygen is not available on all platforms (such as
    Windows).
    
    This changes the Python API a bit:
    
    - generate_ssh_key now returns the private and public ssh keys, and does not
      write to a file.
    
    - encrypt_file has been removed and replaced with encrypt_to_file, which
      encrypts contents and writes them to a file.
    
    Fixes #301.
    asmeurer committed Apr 10, 2018
    Copy the full SHA
    bc5cc26 View commit details
    Browse the repository at this point in the history
  2. Fix unused keyword argument

    asmeurer committed Apr 10, 2018
    Copy the full SHA
    ac17856 View commit details
    Browse the repository at this point in the history
  3. Remove the note parameter to generate_ssh_key()

    It was not being used by the cryptography generation. I could probably still
    add it in, but as far as I can tell, the note is not visible from GitHub
    anyway (and the public ssh key is not used anywhere else). GitHub shows its
    own note, which is set by the title parameter of upload_GitHub_deploy_key().
    asmeurer committed Apr 10, 2018
    Copy the full SHA
    ba7317a View commit details
    Browse the repository at this point in the history
  4. Add .DS_Store to .gitignore

    asmeurer committed Apr 10, 2018
    Copy the full SHA
    5ccea1c View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    1ef7a86 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    a52e6bb View commit details
    Browse the repository at this point in the history