Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Loop): remove standalone sample_weights parameter, rely exclusively on events' sample weights #523

Merged
merged 4 commits into from
Oct 9, 2023

Conversation

almostintuitive
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #523 (2e1cb83) into main (981d7e0) will decrease coverage by 0.08%.
Report is 1 commits behind head on main.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##             main     #523      +/-   ##
==========================================
- Coverage   89.59%   89.51%   -0.08%     
==========================================
  Files         102      102              
  Lines        4794     4768      -26     
==========================================
- Hits         4295     4268      -27     
- Misses        499      500       +1     
Files Coverage Δ
src/fold/base/classes.py 87.40% <100.00%> (+0.32%) ⬆️
src/fold/loop/backtesting.py 94.11% <100.00%> (ø)
src/fold/loop/encase.py 90.00% <ø> (ø)
src/fold/loop/training.py 84.37% <100.00%> (ø)
tests/fold/unit/test_events.py 100.00% <100.00%> (ø)
tests/fold/unit/test_loop.py 100.00% <ø> (ø)
tests/fold/unit/test_model.py 100.00% <100.00%> (ø)
tests/fold/unit/test_utils.py 100.00% <ø> (ø)
src/fold/loop/updating.py 52.94% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@szemyd szemyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@almostintuitive almostintuitive merged commit 559ae9b into main Oct 9, 2023
17 of 18 checks passed
@almostintuitive almostintuitive deleted the fix/sample-weights branch October 9, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants