Skip to content

Commit

Permalink
fix(design): fix slider to stop responding to mouse movement after re…
Browse files Browse the repository at this point in the history
…lease during zoom operations (#1834)
  • Loading branch information
jikkai committed Apr 9, 2024
1 parent 52b2698 commit 3d5a26e
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions packages/design/src/components/slider/Slider.tsx
Expand Up @@ -132,17 +132,17 @@ export function Slider(props: ISliderProps) {

function onMouseUp() {
isDragging = false;
document.removeEventListener('mousemove', onMouseMove);
window.removeEventListener('mouseup', onMouseUp);
document.removeEventListener('pointermove', onMouseMove);
window.removeEventListener('pointerup', onMouseUp);
}

function onMouseOut(e: MouseEvent) {
e.relatedTarget === null && onMouseUp();
}

document.addEventListener('mousemove', onMouseMove);
window.addEventListener('mouseup', onMouseUp);
window.addEventListener('mouseout', onMouseOut);
window.addEventListener('pointermove', onMouseMove);
window.addEventListener('pointerup', onMouseUp);
window.addEventListener('pointerout', onMouseOut);
}

return (
Expand All @@ -167,7 +167,7 @@ export function Slider(props: ISliderProps) {
style={{
left: `${offset}%`,
}}
onMouseDown={handleMouseDown}
onPointerDown={handleMouseDown}
/>
</div>
</div>
Expand Down

0 comments on commit 3d5a26e

Please sign in to comment.