fix(sheet): the icons for hiding rows and columns do not disappear. (#…

…1527)
dream-num · Mar 9, 2024 · 598e7eb · 598e7eb
1 parent b539012
commit 598e7eb
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 12 deletions.
diff --git a/examples/src/data/sheets/demo/default-workbook-data-demo.ts b/examples/src/data/sheets/demo/default-workbook-data-demo.ts
@@ -13841,7 +13841,17 @@ export const DEFAULT_WORKBOOK_DATA_DEMO: IWorkbookData = {
             defaultColumnWidth: 73,
             defaultRowHeight: 19,
             mergeData: [],
-            rowData: {},
+            rowData: {
+                14: {
+                    hd: 1,
+                },
+                15: {
+                    hd: 1,
+                },
+                16: {
+                    hd: 1,
+                },
+            },
             columnData: {},
             showGridlines: 1,
             rowHeader: {

diff --git a/packages/core/src/types/interfaces/i-column-data.ts b/packages/core/src/types/interfaces/i-column-data.ts
@@ -23,9 +23,9 @@ export interface IColumnData {
     /**
      * width
      */
-    w: number;
+    w?: number;
     /**
      * hidden
      */
-    hd: BooleanNumber;
+    hd?: BooleanNumber;
 }
diff --git a/packages/core/src/types/interfaces/i-row-data.ts b/packages/core/src/types/interfaces/i-row-data.ts
@@ -23,7 +23,7 @@ export interface IRowData {
     /**
      * height in pixel
      */
-    h: number;
+    h?: number;
     /**
      * is current row self-adaptive to its content, use `ah` to set row height when true, else use `h`.
      */
@@ -35,5 +35,5 @@ export interface IRowData {
     /**
      * hidden
      */
-    hd: BooleanNumber;
+    hd?: BooleanNumber;
 }
diff --git a/packages/sheets-ui/src/controllers/header-unhide.controller.ts b/packages/sheets-ui/src/controllers/header-unhide.controller.ts
@@ -79,13 +79,6 @@ export class HeaderUnhideController extends RxDisposable {
             return;
         }
 
-        // Try to render the unhide button for the current worksheet.
-        const workbook = this._univerInstanceService.getCurrentUniverSheetInstance();
-        const worksheet = workbook.getActiveSheet();
-        if (worksheet) {
-            this._initForWorksheet(workbook, worksheet);
-        }
-
         // Re-render when sheet skeleton changes.
         this._sheetSkeletonManagerService.currentSkeleton$
             .pipe(takeUntil(this.dispose$), startWith(undefined), pairwise())