fix(sheet): header hidden (#1954)

dream-num · Apr 17, 2024 · e3dc9ce · e3dc9ce
1 parent 2564456
commit e3dc9ce
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/examples/src/slides/main.ts b/examples/src/slides/main.ts
@@ -21,6 +21,7 @@ import { UniverSlidesPlugin } from '@univerjs/slides';
 import { UniverSlidesUIPlugin } from '@univerjs/slides-ui';
 import { UniverUIPlugin } from '@univerjs/ui';
 
+import { UniverFormulaEnginePlugin } from '@univerjs/engine-formula';
 import { DEFAULT_SLIDE_DATA } from '../data';
 
 // univer
@@ -31,6 +32,7 @@ const univer = new Univer({
 
 // base-render
 univer.registerPlugin(UniverRenderEnginePlugin);
+univer.registerPlugin(UniverFormulaEnginePlugin);
 univer.registerPlugin(UniverUIPlugin, {
     container: 'univer-container',
     header: true,

diff --git a/packages/engine-render/src/components/sheets/extensions/column-header-layout.ts b/packages/engine-render/src/components/sheets/extensions/column-header-layout.ts
@@ -35,7 +35,7 @@ export class ColumnHeaderLayout extends SheetExtension {
         const { rowColumnSegment, columnHeaderHeight = 0 } = spreadsheetSkeleton;
         const { startColumn, endColumn } = rowColumnSegment;
 
-        if (!spreadsheetSkeleton) {
+        if (!spreadsheetSkeleton || columnHeaderHeight === 0) {
             return;
         }
 

diff --git a/packages/engine-render/src/components/sheets/extensions/row-header-layout.ts b/packages/engine-render/src/components/sheets/extensions/row-header-layout.ts
@@ -31,9 +31,9 @@ export class RowHeaderLayout extends SheetExtension {
     override Z_INDEX = 10;
 
     override draw(ctx: UniverRenderingContext, parentScale: IScale, spreadsheetSkeleton: SpreadsheetSkeleton) {
-        const { rowColumnSegment, rowHeaderWidth = 0, columnHeaderHeight = 0 } = spreadsheetSkeleton;
-        const { startRow, endRow, startColumn, endColumn } = rowColumnSegment;
-        if (!spreadsheetSkeleton) {
+        const { rowColumnSegment, rowHeaderWidth = 0 } = spreadsheetSkeleton;
+        const { startRow, endRow } = rowColumnSegment;
+        if (!spreadsheetSkeleton || rowHeaderWidth === 0) {
             return;
         }