Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheet): optimize sheet render #1245

Merged
merged 100 commits into from Feb 18, 2024
Merged

feat(sheet): optimize sheet render #1245

merged 100 commits into from Feb 18, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Jan 24, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 211 lines in your changes are missing coverage. Please review.

Comparison is base (b289174) 29.75% compared to head (757f037) 29.66%.

Files Patch % Lines
packages/core/src/sheets/worksheet.ts 0.00% 56 Missing ⚠️
...engine-render/src/components/sheets/spreadsheet.ts 0.00% 32 Missing ⚠️
packages/engine-render/src/context.ts 0.00% 19 Missing ⚠️
...ui/src/views/components/global-zone/GlobalZone.tsx 0.00% 18 Missing ⚠️
...ervices/global-zone/desktop-global-zone.service.ts 0.00% 16 Missing ⚠️
packages/engine-render/src/engine.ts 0.00% 14 Missing ⚠️
...-ui/src/services/sheet-skeleton-manager.service.ts 8.33% 11 Missing ⚠️
...der/src/components/sheets/extensions/background.ts 0.00% 8 Missing ⚠️
packages/engine-render/src/canvas.ts 0.00% 7 Missing ⚠️
...ne-render/src/components/sheets/extensions/font.ts 0.00% 7 Missing ⚠️
... and 15 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1245      +/-   ##
==========================================
- Coverage   29.75%   29.66%   -0.10%     
==========================================
  Files         845      848       +3     
  Lines       47931    48081     +150     
  Branches     9832     9872      +40     
==========================================
  Hits        14262    14262              
- Misses      33669    33819     +150     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Codecov Report

Attention: 110 lines in your changes are missing coverage. Please review.

Comparison is base (3c67252) 29.62% compared to head (3fccd8d) 29.58%.

Files Patch % Lines
packages/core/src/sheets/worksheet.ts 0.00% 25 Missing ⚠️
...ges/ui/src/services/print/desktop-print.service.ts 0.00% 15 Missing ⚠️
...engine-render/src/components/sheets/spreadsheet.ts 0.00% 13 Missing and 1 partial ⚠️
packages/engine-render/src/engine.ts 0.00% 12 Missing and 2 partials ⚠️
packages/engine-render/src/context.ts 0.00% 13 Missing ⚠️
packages/ui/src/views/components/print/Print.tsx 0.00% 9 Missing and 4 partials ⚠️
packages/engine-render/src/canvas.ts 0.00% 5 Missing and 2 partials ⚠️
packages/engine-render/src/viewport.ts 0.00% 0 Missing and 2 partials ⚠️
...-ui/src/services/sheet-skeleton-manager.service.ts 0.00% 2 Missing ⚠️
...s/design/src/components/form-layout/FormLayout.tsx 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1245      +/-   ##
==========================================
- Coverage   29.62%   29.58%   -0.05%     
==========================================
  Files         829      832       +3     
  Lines       46865    46930      +65     
  Branches     9591     9602      +11     
==========================================
  Hits        13885    13885              
- Misses      28765    28827      +62     
- Partials     4215     4218       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 24, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

package.json Outdated Show resolved Hide resolved
@weird94 weird94 changed the title WIP: sheet print feat(sheet): optimize sheet render Jan 25, 2024
@weird94
Copy link
Contributor Author

weird94 commented Jan 25, 2024

@zhaolixin7 这个分支对sheet渲染流程进行了改动,麻烦回归一下sheet渲染各种case下是否存在问题

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@zhaolixin7 This branch has made changes to the sheet rendering process. Please return to see if there are any problems in various cases of sheet rendering.

@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Feb 2, 2024
packages/core/src/sheets/worksheet.ts Outdated Show resolved Hide resolved
packages/engine-render/src/canvas.ts Show resolved Hide resolved
packages/ui/src/views/App.tsx Outdated Show resolved Hide resolved
packages/ui/src/index.ts Outdated Show resolved Hide resolved
packages/ui/src/services/global-zone/index.ts Outdated Show resolved Hide resolved
packages/ui/src/common/component-manager.ts Outdated Show resolved Hide resolved
packages/engine-render/src/components/extension.ts Outdated Show resolved Hide resolved
@weird94 weird94 merged commit 33bc465 into dev Feb 18, 2024
7 checks passed
@weird94 weird94 deleted the feat/print branch February 18, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants