Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): sum get error when cell has error #1306

Merged
merged 5 commits into from Feb 7, 2024
Merged

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Jan 31, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #1268

Copy link

github-actions bot commented Jan 31, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Dushusir Dushusir changed the title fix(formula): sum get error fix(formula): sum get error when cell has error Jan 31, 2024
@Dushusir Dushusir added the qa:untested This PR is ready to be tested label Jan 31, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (157b4db) 29.70% compared to head (7571351) 29.73%.

Files Patch % Lines
...ormula/src/engine/value-object/primitive-object.ts 20.00% 4 Missing ⚠️
packages/engine-formula/src/engine/utils/cell.ts 83.33% 2 Missing ⚠️
...mula/src/engine/value-object/array-value-object.ts 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1306      +/-   ##
==========================================
+ Coverage   29.70%   29.73%   +0.02%     
==========================================
  Files         844      845       +1     
  Lines       47913    47921       +8     
  Branches     9825     9827       +2     
==========================================
+ Hits        14233    14247      +14     
+ Misses      33680    33674       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Feb 2, 2024
@Dushusir Dushusir marked this pull request as ready for review February 2, 2024 09:10
@Dushusir Dushusir merged commit a13c450 into dev Feb 7, 2024
7 checks passed
@Dushusir Dushusir deleted the dushusir/f-bug2 branch February 7, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 公式等于多个选区,修改选区范围后公式计算结果错误
3 participants