New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(formula): sum get error when cell has error #1306
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View Deployment
|
Dushusir
force-pushed
the
dushusir/f-bug2
branch
from
January 31, 2024 09:29
bada503
to
225ef16
Compare
Dushusir
changed the title
fix(formula): sum get error
fix(formula): sum get error when cell has error
Jan 31, 2024
Dushusir
force-pushed
the
dushusir/f-bug2
branch
from
February 1, 2024 04:03
4c59a46
to
e20eaa6
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #1306 +/- ##
==========================================
+ Coverage 29.70% 29.73% +0.02%
==========================================
Files 844 845 +1
Lines 47913 47921 +8
Branches 9825 9827 +2
==========================================
+ Hits 14233 14247 +14
+ Misses 33680 33674 -6 ☔ View full report in Codecov by Sentry. |
zhaolixin7
added
qa:verified
This PR has already by verified by a QA and is considered good enough to be merge
and removed
qa:untested
This PR is ready to be tested
labels
Feb 2, 2024
Dushusir
force-pushed
the
dushusir/f-bug2
branch
2 times, most recently
from
February 7, 2024 09:50
9169a42
to
2f4a963
Compare
Dushusir
requested review from
yuhongz,
Gggpound,
wzhudev,
jikkai and
Jocs
as code owners
February 7, 2024 09:50
Dushusir
force-pushed
the
dushusir/f-bug2
branch
from
February 7, 2024 09:59
2f4a963
to
7571351
Compare
DR-Univer
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
qa:verified
This PR has already by verified by a QA and is considered good enough to be merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev
branch.close #1268