Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add isEditing param #1428

Merged
merged 2 commits into from Feb 28, 2024
Merged

feat: add isEditing param #1428

merged 2 commits into from Feb 28, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Feb 28, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #

Copy link

github-actions bot commented Feb 28, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 35.71429% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 31.30%. Comparing base (8db5c06) to head (3072476).

Files Patch % Lines
...c/components/docs/text-selection-render-manager.ts 0.00% 4 Missing ⚠️
...ocs/src/services/text-selection-manager.service.ts 62.50% 3 Missing ⚠️
...cs/src/commands/operations/select-all.operation.ts 0.00% 1 Missing ⚠️
...rc/commands/operations/text-selection.operation.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1428   +/-   ##
=======================================
  Coverage   31.30%   31.30%           
=======================================
  Files         876      876           
  Lines       49085    49085           
  Branches    10129    10132    +3     
=======================================
  Hits        15366    15366           
  Misses      33719    33719           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs Jocs marked this pull request as ready for review February 28, 2024 07:29
@Jocs Jocs merged commit aa92e60 into dev Feb 28, 2024
7 checks passed
@Jocs Jocs deleted the feat/non-editing-cursor-change branch February 28, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants