fix(design): fix z-index for SubMenu
#1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1440 +/- ##
=======================================
Coverage 31.26% 31.26%
=======================================
Files 876 876
Lines 49145 49145
Branches 10139 10139
=======================================
Hits 15364 15364
Misses 33781 33781 ☔ View full report in Codecov by Sentry. |
wzhudev
approved these changes
Mar 1, 2024
| @@ -100,7 +100,7 @@ | |||
| &-submenu { | |||
| &-popup { | |||
| position: absolute; | |||
| z-index: 1; | |||
| z-index: 1070; | |||
There was a problem hiding this comment.
我建议提前把 z-index 分成哪几个区域，每个区域分给哪些组件（包括业务组件），提前确定一下，形成个文档；不然（根据之前做的项目来看）长期来看可能会混乱
There was a problem hiding this comment.
这个有计划做，这周 storybook 恢复以后会增加相关的 z-index token 到文档上
Jocs
approved these changes
Mar 1, 2024
zhaolixin7
added
qa:verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devbranch.close #1434